-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic scoring & reduce pubsub spam #573
Conversation
Stebalien
commented
Aug 14, 2024
- Add topic scoring to both the GPBFT topic and the manifest topic.
- Use hashing for message IDs in the manifest network and increase the rebroadcast time.
- In the manifest validator, drop messages with old sequence numbers.
9fd30d7
to
c38cfb2
Compare
Bump the pubsub topic versions at the same time? |
c38cfb2
to
544544d
Compare
1. Add topic scoring to both the GPBFT topic and the manifest topic. 2. Hash the data + topic for GPBFT messages. 3. Hash the data + sender + topic for manifest sever messages. We need to include the sender because we reject messages from invalid senders. 4. In the manifest validator, drop messages with old sequence numbers.
d5b83ea
to
a2201eb
Compare
Just use the configured interval.
Fuzz test failed on commit 9bdf53b. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 10393399687 -n testdata Alternatively, download directly from here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 80.03% 79.75% -0.28%
==========================================
Files 49 50 +1
Lines 4492 4525 +33
==========================================
+ Hits 3595 3609 +14
- Misses 547 562 +15
- Partials 350 354 +4
|
Fuzz test failed on commit bfc8af6. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 10393581939 -n testdata Alternatively, download directly from here. |