use mathutil for ticket calculations #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Stebalien
force-pushed
the
steb/min-ticket-mathutil
branch
from
f62d9e1 to
9bb6034
Compare
Stebalien
commented
Aug 22, 2024
| var minTicket float64 = math.Inf(1) | ||
| var minTicket *big.Float | ||
|
|
||
| const precision = 257 |
There was a problem hiding this comment.
Based on the upstream example. I assume there's a reason they use the extra precision bit.
Stebalien
commented
Aug 22, 2024
| c = 256 - c | ||
| ticketF := big.NewFloat(0).SetPrec(precision).SetInt(m) | ||
| ticketF.SetMantExp(ticketF, -precision) | ||
| ticketF.Add(ticketF, big.NewFloat(float64(c))) |
There was a problem hiding this comment.
Hm. Do we need more precision for this (+8 bits)?
Stebalien
force-pushed
the
steb/min-ticket-mathutil
branch
from
9bb6034 to
cdb6762
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test/deny-quality2 #580 +/- ##
======================================================
- Coverage 79.75% 79.41% -0.35%
======================================================
Files 50 50
Lines 4525 4532 +7
======================================================
- Hits 3609 3599 -10
- Misses 563 574 +11
- Partials 353 359 +6
|
Kubuxu
force-pushed
the
test/deny-quality2
branch
from
06a26eb to
7297962
Compare
|
Superceeded by #578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.