Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of late-arriving COMMITs #609

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

masih
Copy link
Member

@masih masih commented Aug 30, 2024

Move the handling of late-arriving COMMITs into switch statement for consistent code style and better readability.

Move the handling of late-arriving COMMITs into switch statement for
consistent code style and better readability.
@masih masih requested review from Stebalien and Kubuxu August 30, 2024 16:55
@masih masih enabled auto-merge August 30, 2024 16:55
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (e3a71f8) to head (b2c22ec).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   79.50%   78.87%   -0.63%     
==========================================
  Files          52       52              
  Lines        4630     4630              
==========================================
- Hits         3681     3652      -29     
- Misses        591      613      +22     
- Partials      358      365       +7     
Files with missing lines Coverage Δ
gpbft/gpbft.go 87.24% <100.00%> (ø)

... and 5 files with indirect coverage changes

@masih masih added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 7e9ab6e Aug 30, 2024
13 checks passed
@masih masih deleted the masih/recieve-one-cleanup branch August 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants