Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test ticket quality computation #630

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

masih
Copy link
Member

@masih masih commented Sep 5, 2024

Test ticket quality

  • is weighed by power
  • is as expected for edge case power value
  • handles unexpected ticket length gracefully

Part of #9

@masih masih requested a review from Kubuxu September 5, 2024 13:22
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (2dd4f5d) to head (1c15fad).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   79.45%   79.63%   +0.18%     
==========================================
  Files          52       52              
  Lines        4644     4646       +2     
==========================================
+ Hits         3690     3700      +10     
+ Misses        592      588       -4     
+ Partials      362      358       -4     
Files with missing lines Coverage Δ
gpbft/ticket_quality.go 84.61% <100.00%> (+1.28%) ⬆️

... and 4 files with indirect coverage changes

@masih masih requested a review from Stebalien September 5, 2024 14:13
gpbft/ticket_quality_test.go Outdated Show resolved Hide resolved
Test ticket quality
* is weighed by power
* is as expected for edge case power value
* handles unexpected ticket length gracefully

Part of #9
@masih masih force-pushed the masih/test-tickets-are-weighed-by-power branch from b3eb360 to 1c15fad Compare September 5, 2024 15:43
@masih masih enabled auto-merge September 5, 2024 15:48
@masih masih added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit ff0b6f5 Sep 5, 2024
13 checks passed
@masih masih deleted the masih/test-tickets-are-weighed-by-power branch September 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants