Drop messages that are no longer useful for GPBFT progression #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
4cb81c0 to
e6a8851
Compare
|
Fuzz test failed on commit 4cb81c0. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 10960282602 -n testdataAlternatively, download directly from here. |
|
Fuzz test failed on commit e6a8851. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 10960300308 -n testdataAlternatively, download directly from here. |
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
4 times, most recently
from
1b50bb8 to
92b32f2
Compare
|
Fuzz test failed on commit 92b32f2. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 10973051853 -n testdataAlternatively, download directly from here. |
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
92b32f2 to
a0e155b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 76.94% 76.58% -0.37%
==========================================
Files 65 65
Lines 5487 5496 +9
==========================================
- Hits 4222 4209 -13
- Misses 861 878 +17
- Partials 404 409 +5
|
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
a0e155b to
fb2badd
Compare
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
fb2badd to
31e65c1
Compare
masih
force-pushed
the
masih/validation-refactor
branch
2 times, most recently
from
380fc6c to
5c00dc0
Compare
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
2 times, most recently
from
628ff0a to
a9c2397
Compare
masih
force-pushed
the
masih/validation-refactor
branch
2 times, most recently
from
13cb79b to
9fad427
Compare
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
2 times, most recently
from
70639ba to
7975dfe
Compare
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
7975dfe to
984caa9
Compare
Stebalien
reviewed
Sep 23, 2024
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
984caa9 to
7dda4e8
Compare
As a GPBFT instance progresses some messages become irrelevant, in that they do not effectively aid the progress of the instance for participants. Instead, GPBFT offers other built-in mechanisms to aid progress of lagging participants such as selective rebroadcast, propagation of DECIDE messages from the previous instance and finality certificate exchange. The changes here introduce a dedicated error type returned as part of message validation to signal that although a message is valid it is no longer relevant. This error type is then checked by pubsub to avoid further propagation of those messages. This reduces the redundant pubsub traffic for the network participants. Fixes #583
masih
force-pushed
the
masih/pubsub-ignore-irrelevant-msgs
branch
from
7dda4e8 to
0503f70
Compare
Stebalien
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a GPBFT instance progresses some messages become irrelevant, in that they do not effectively aid the progress of the instance for participants. Instead, GPBFT offers other built-in mechanisms to aid progress of lagging participants such as selective rebroadcast, propagation of DECIDE messages from the previous instance and finality certificate exchange.
The changes here introduce a dedicated error type returned as part of message validation to signal that although a message is valid it is no longer relevant. This error type is then checked by pubsub to avoid further propagation of those messages.
This reduces the redundant pubsub traffic for the network participants.
Fixes #583