Refactor Chain interface into separate do-er interfaces
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/chain-interface-refactor-committee-cache
branch
2 times, most recently
from
b751eb0 to
aabb38e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 79.32% 79.04% -0.29%
==========================================
Files 54 55 +1
Lines 4886 4906 +20
==========================================
+ Hits 3876 3878 +2
- Misses 633 645 +12
- Partials 377 383 +6
|
masih
force-pushed
the
masih/chain-interface-refactor-committee-cache
branch
from
aabb38e to
259aa08
Compare
Stebalien
approved these changes
Sep 23, 2024
Refactor the `Chain` interface into two separate smaller interfaces for a more pluggable committee caching. Refactor committee cache out of participant. This work is part of a larger refactor of validation mechanism and is separated into its own commit for easier review. Part of #561
masih
force-pushed
the
masih/chain-interface-refactor-committee-cache
branch
from
259aa08 to
7fae253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
Chaininterface into two separate smaller interfaces for a more pluggable committee caching.Refactor committee cache out of participant.
This work is part of a larger refactor of validation mechanism and is separated into its own commit for easier review.
Part of #561