Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce GOGC in fuzz tests #667

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Reduce GOGC in fuzz tests #667

merged 1 commit into from
Sep 27, 2024

Conversation

masih
Copy link
Member

@masih masih commented Sep 27, 2024

Investigate false negative fuzz test failures due to hitting memory limit by reverting GOGC back to default 100.

Fixes #666

Investigate false negative fuzz test failures due to hitting memory
limit by reverting GOGC back to default 100.

Fixes #666
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (46a498f) to head (8d58db6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   76.43%   76.26%   -0.17%     
==========================================
  Files          65       65              
  Lines        5393     5393              
==========================================
- Hits         4122     4113       -9     
- Misses        873      878       +5     
- Partials      398      402       +4     

see 5 files with indirect coverage changes

@masih
Copy link
Member Author

masih commented Sep 27, 2024

Repeated fuzzing 3 times with the changes here and the time it take for the fuzzing to run is more or less the same as the time it takes on main.

All three attempts succeeded.

@masih masih marked this pull request as ready for review September 27, 2024 09:34
@masih masih requested a review from Stebalien September 27, 2024 09:34
@masih masih enabled auto-merge September 27, 2024 09:35
@masih masih added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 94641f7 Sep 27, 2024
13 checks passed
@masih masih deleted the masih/investigate-fuzz-failures branch September 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate sporadic fuzz failures with exit code 143
2 participants