Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose access to progress on f3 runner #673

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

masih
Copy link
Member

@masih masih commented Sep 30, 2024

The root F3 instance holds reference to the gpbftRunner, not gpbftHost. To allow access to current progress from Lotus, move the Progress implementation to runner and expose at root F3 type.

Part of #599

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (70ae074) to head (b15c886).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
f3.go 0.00% 4 Missing ⚠️
host.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   76.41%   76.27%   -0.14%     
==========================================
  Files          65       65              
  Lines        5388     5392       +4     
==========================================
- Hits         4117     4113       -4     
- Misses        877      884       +7     
- Partials      394      395       +1     
Files with missing lines Coverage Δ
host.go 69.52% <0.00%> (-0.24%) ⬇️
f3.go 62.61% <0.00%> (-1.15%) ⬇️

... and 3 files with indirect coverage changes

@masih masih marked this pull request as ready for review October 1, 2024 19:46
@masih masih requested a review from Stebalien October 1, 2024 19:46
@masih masih enabled auto-merge October 1, 2024 19:47
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a rebase.

@masih masih added this pull request to the merge queue Oct 1, 2024
@Stebalien Stebalien removed this pull request from the merge queue due to a manual request Oct 1, 2024
@masih masih force-pushed the masih/progress-runner branch from 7ad42da to 8551760 Compare October 1, 2024 20:02
The root F3 instance holds reference to the `gpbftRunner`, not
`gpbftHost`. To allow access to current progress from Lotus, move the
`Progress` implementation to runner and expose at root `F3` type.

Part of #599
@masih masih force-pushed the masih/progress-runner branch from 8551760 to b15c886 Compare October 1, 2024 20:07
@masih masih enabled auto-merge October 1, 2024 20:23
@masih masih added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 9556aff Oct 1, 2024
12 of 13 checks passed
@masih masih deleted the masih/progress-runner branch October 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants