Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve powerstore error handling #676

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien changed the base branch from main to steb/robust-deliver-alarm September 30, 2024 19:24
@Stebalien Stebalien changed the base branch from steb/robust-deliver-alarm to main September 30, 2024 19:24
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (c438aa5) to head (caafbc8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/powerstore/powerstore.go 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   76.24%   76.18%   -0.06%     
==========================================
  Files          65       65              
  Lines        5421     5422       +1     
==========================================
- Hits         4133     4131       -2     
- Misses        884      889       +5     
+ Partials      404      402       -2     
Files with missing lines Coverage Δ
internal/powerstore/powerstore.go 64.50% <33.33%> (-0.83%) ⬇️

... and 4 files with indirect coverage changes

@Stebalien Stebalien added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 6c0427f Sep 30, 2024
12 of 13 checks passed
@Stebalien Stebalien deleted the steb/powerstore-error-handling branch September 30, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants