Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag validation errors for non-relevant messages #766

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

masih
Copy link
Member

@masih masih commented Nov 29, 2024

Add the missing custom tag for ErrValidationNotRelevant type as invalid_not_relevant.

@masih masih requested a review from rjan90 November 29, 2024 14:53
Add the missing custom tag for `ErrValidationNotRelevant` type as
`invalid_not_relevant`.
@masih masih force-pushed the masih/tag-not-relevan-err-metrics branch from bf2e8d4 to 0ccc1a6 Compare November 29, 2024 14:53
@masih masih enabled auto-merge November 29, 2024 14:54
@masih masih added this pull request to the merge queue Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (483e58b) to head (0ccc1a6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   69.65%   69.38%   -0.27%     
==========================================
  Files          74       74              
  Lines        7551     7553       +2     
==========================================
- Hits         5260     5241      -19     
- Misses       1877     1895      +18     
- Partials      414      417       +3     
Files with missing lines Coverage Δ
gpbft/metrics.go 62.06% <100.00%> (-4.60%) ⬇️

... and 3 files with indirect coverage changes

Merged via the queue into main with commit 9b04b56 Nov 29, 2024
13 checks passed
@masih masih deleted the masih/tag-not-relevan-err-metrics branch November 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants