-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework time dilution in F3 tests and refine assertions #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84bdd9f
to
3606fdd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 67.28% 67.14% -0.14%
==========================================
Files 84 84
Lines 9175 9175
==========================================
- Hits 6173 6161 -12
- Misses 2459 2467 +8
- Partials 543 547 +4
|
Hold off on reviews until I crack the intermittent failures on CI. Regardless, early feedback is always welcomed 🙏 |
533d689
to
0791531
Compare
@Kubuxu this is ready for review whenever you get a chance. Thanks |
Kubuxu
approved these changes
Jan 31, 2025
0791531
to
8ad4a96
Compare
7a0f51d
to
0084ea9
Compare
0084ea9
to
b2c690e
Compare
f4d64bd
to
6d8b5df
Compare
91ff1cb
to
b2f5e47
Compare
b2f5e47
to
26c7e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress the clock during tests independently of condition check. Rework the assertions to use built-in eventual assertion. Use consistent names for the asserting functions.
Fixes #818
Fixes #847