Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework time dilution in F3 tests and refine assertions #862

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 30, 2025

Progress the clock during tests independently of condition check. Rework the assertions to use built-in eventual assertion. Use consistent names for the asserting functions.

Fixes #818
Fixes #847

@masih masih force-pushed the masih/fix-flaky-f3-teste branch 2 times, most recently from 84bdd9f to 3606fdd Compare January 30, 2025 20:59
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.14%. Comparing base (e232882) to head (26c7e26).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   67.28%   67.14%   -0.14%     
==========================================
  Files          84       84              
  Lines        9175     9175              
==========================================
- Hits         6173     6161      -12     
- Misses       2459     2467       +8     
- Partials      543      547       +4     
Files with missing lines Coverage Δ
partial_msg.go 56.94% <100.00%> (+1.35%) ⬆️

... and 10 files with indirect coverage changes

@BigLep BigLep added this to the M2: Mainnet Passive Testing milestone Jan 30, 2025
@BigLep BigLep requested a review from Kubuxu January 30, 2025 23:10
@masih
Copy link
Member Author

masih commented Jan 31, 2025

Hold off on reviews until I crack the intermittent failures on CI. Regardless, early feedback is always welcomed 🙏

@masih masih force-pushed the masih/fix-flaky-f3-teste branch 2 times, most recently from 533d689 to 0791531 Compare January 31, 2025 18:12
@masih
Copy link
Member Author

masih commented Jan 31, 2025

@Kubuxu this is ready for review whenever you get a chance. Thanks

@masih masih added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@masih masih force-pushed the masih/fix-flaky-f3-teste branch from 0791531 to 8ad4a96 Compare January 31, 2025 19:01
@masih masih enabled auto-merge January 31, 2025 19:01
@masih masih force-pushed the masih/fix-flaky-f3-teste branch 2 times, most recently from 7a0f51d to 0084ea9 Compare February 3, 2025 10:46
@masih masih added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@masih masih force-pushed the masih/fix-flaky-f3-teste branch from 0084ea9 to b2c690e Compare February 3, 2025 11:39
@masih masih enabled auto-merge February 3, 2025 11:40
@masih masih force-pushed the masih/fix-flaky-f3-teste branch 4 times, most recently from f4d64bd to 6d8b5df Compare February 5, 2025 10:41
@masih masih added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@masih masih force-pushed the masih/fix-flaky-f3-teste branch from 91ff1cb to b2f5e47 Compare February 5, 2025 15:00
Progress the clock during tests independently of condition check. Rework
the assertions to use built-in eventual assertion. Use consistent names
for the asserting functions.

Fixes #818
Fixes #847
@masih masih force-pushed the masih/fix-flaky-f3-teste branch from b2f5e47 to 26c7e26 Compare February 5, 2025 15:05
@masih masih added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 146ffe4 Feb 5, 2025
14 checks passed
@masih masih deleted the masih/fix-flaky-f3-teste branch February 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TestF3LateBootstrap is flaky Review and rewrite more explicit assertion logic for f3_test.go
3 participants