fix: handle error AND zero-length cases from piece lookup

filecoin-project · Oct 14, 2022 · e051f00 · e051f00
1 parent d87dada
commit e051f00
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/retrievalmarket/impl/provider_pieces.go b/retrievalmarket/impl/provider_pieces.go
@@ -64,9 +64,12 @@ func (p *Provider) getCommonPiecesFromIdentityCidLinks(payloadCID cid.Cid) ([]ci
 	// for each link, query the dagstore for pieces that contain it
 	for i, link := range links {
 		piecesWithThisCid, err := p.dagStore.GetPiecesContainingBlock(link)
-		if len(piecesWithThisCid) == 0 {
+		if err != nil {
 			return nil, fmt.Errorf("getting pieces for identity CID sub-link %s: %w", link, err)
 		}
+		if len(piecesWithThisCid) == 0 {
+			return nil, fmt.Errorf("no pieces for identity CID sub-link %s", link)
+		}
 		if i == 0 {
 			pieces = append(pieces, piecesWithThisCid...)
 		} else {