-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send state identifiery when getting miner worker address #153
send state identifiery when getting miner worker address #153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 82.07% 81.76% -0.30%
==========================================
Files 33 33
Lines 1561 1573 +12
==========================================
+ Hits 1281 1286 +5
- Misses 200 204 +4
- Partials 80 83 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but two comments I'm hoping you can answer before you hit that merge button...
- does an address lookup really change based on the TipSet key?
- just curious -- why the method rename?
Yep, see here. A storage miner actor's worker address may be X at block height H and X' at H'. Passing the tipset key allows disambiguation when chain queries from the provider span multiple chain heads.
I changed the method name to match what's in go-storage-miner. I could change what's in go-storage-miner to match what's in go-fil-markets, I suppose - but I'm already making edits to this codebase. What do you prefer? |
Oops. I linked to the wrong part of specs-actors. See this link for more info. |
all good! LGTM |
Makes incremental progress towards #148.