Feat/configure start epoch buffer #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return p.dealAcceptanceBuffer | ||
| } | ||
|
|
||
| func (p *Provider) UniversalRetrievalEnabled() bool { |
There was a problem hiding this comment.
What is the value of these functions if they are not added to the StorageProvider interface type? Should they be? I'm not sure they should?
Oh, nm, you're using them for testing. Makes sense. +1
hannahhoward
approved these changes
Mar 26, 2020
| @@ -339,4 +361,8 @@ func (p *providerDealEnvironment) Disconnect(proposalCid cid.Cid) error { | |||
| return p.p.conns.Disconnect(proposalCid) | |||
| } | |||
|
|
|||
| func (p *providerDealEnvironment) DealAcceptanceBuffer() abi.ChainEpoch { | |||
There was a problem hiding this comment.
So I've gone back and forth a bunch on this, but I wonder if we should throw out the providerDealEnvironment and just make these methods on the Provider, cause we have the same aforementioned feature above -- the methods aren't accessible assuming you just have the storage provider interface. Non-blocking, but what do you think?
There was a problem hiding this comment.
I like implementing the interface on our provider impl; it would remove a bunch of indirection.
ingar
force-pushed
the
feat/configure-start-epoch-buffer
branch
from
2bcf854
to
d510a39
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a configurable
DealAcceptanceBuffer, which can be used by storage providers to adjust how far in the future a deal'sStartEpochmust be in order to be accepted. This is to account for time required for data transfer, deal publishing, sealing, committing, etc.Resolves #139