Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selector to BlockIO classes #178

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

shannonwells
Copy link
Contributor

closes #169

@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #178 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   68.55%   68.46%   -0.08%     
==========================================
  Files          36       37       +1     
  Lines        1987     1991       +4     
==========================================
+ Hits         1362     1363       +1     
- Misses        528      530       +2     
- Partials       97       98       +1     
Impacted Files Coverage Δ
retrievalmarket/impl/blockio/reader.go 71.43% <100.00%> (ø)
retrievalmarket/impl/blockio/traverser.go 70.24% <100.00%> (-3.87%) ⬇️
retrievalmarket/impl/blockio/verify.go 76.48% <100.00%> (ø)
retrievalmarket/impl/client.go 67.70% <100.00%> (ø)
retrievalmarket/impl/common.go 100.00% <100.00%> (ø)
retrievalmarket/impl/provider.go 70.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f76036...3be764f. Read the comment docs.

@shannonwells shannonwells marked this pull request as ready for review April 1, 2020 22:39
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 473c5d1 into master Apr 1, 2020
@shannonwells shannonwells deleted the feat/blockio-take-selector-#169 branch April 1, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockIO Classes Take a Selector
3 participants