Improve offline deals #183
Conversation
storagemarket/types.go
Outdated
| @@ -426,6 +426,9 @@ type StorageClient interface { | |||
| // ProposeStorageDeal initiates deal negotiation with a Storage Provider | |||
| ProposeStorageDeal(ctx context.Context, addr address.Address, info *StorageProviderInfo, data *DataRef, startEpoch abi.ChainEpoch, endEpoch abi.ChainEpoch, price abi.TokenAmount, collateral abi.TokenAmount, rt abi.RegisteredProof) (*ProposeStorageDealResult, error) | |||
|
|
|||
| // CalculateCommP calculates the piece CID for a given CAR file and miner | |||
There was a problem hiding this comment.
comment seems slightly inaccurate
There was a problem hiding this comment.
@arajasek generally LGTM
One quick question: pieceio.GeneratePieceCommitment is a static, public function, that can be accessed outside go-fil-markets, so I'm not sure about adding this to the storage client as a function: as in the body of the function client.CalculateCommP actually contains (I believe) no references to the actual data variables of the client struct, so my inclination would be to move the contents of this code into the node implementation, to keep the API surface of the client limited only to being for making deals.
Total aside: having lotus make the CAR files and generate commP itself -- does this actually work with the workflow for the team generating the data?
storagemarket/impl/client.go
Outdated
| var pieceSize abi.UnpaddedPieceSize | ||
| var err error | ||
|
|
||
| if data.TransferType != storagemarket.TTManual { |
There was a problem hiding this comment.
the clientutils.CommP function already checks if its a manual transfer and short circuits. Maybe move this logic down into that?
|
Thanks for the suggestions, @hannahhoward, I didn't realise after some edits that I wound up just calling a public static method! I've switched to doing it directly from Lotus, I think it's nicer :) All suggested changes implemented :) |
With these changes, the offline deal workflow succeeds