Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert most protocol changes #236

Merged
merged 1 commit into from
May 9, 2020
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

Unfortuante 0.2.1 includes breaking protocol changes that are not appropriate for a near testnet release. As such, I'm reverting most of them. The original intent was to fix a specific bug near the beginning of the deal, and the fix, while overly fancy would break the network protocol and be unworkable for a single host model with GFC.

Implementation

Revert all changes except:

  • delay opening the stream to the other provider till after funds are insured
  • keep changes of CIDs to pointers

revert handling of incoming streams on client side -- we need more thought into protocol redesign
Copy link
Contributor

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok by me

@hannahhoward hannahhoward merged commit 3b011f6 into master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants