Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieval UnsealPrice (#325) #330

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Jul 22, 2020

Summary

Add states and logic to support setting of and paying for unsealing of data.

Resolves #325

@codecov-commenter
Copy link

Codecov Report

Merging #330 into master will decrease coverage by 0.34%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   63.09%   62.75%   -0.33%     
==========================================
  Files          40       40              
  Lines        2419     2451      +32     
==========================================
+ Hits         1526     1538      +12     
- Misses        787      803      +16     
- Partials      106      110       +4     
Impacted Files Coverage Δ
retrievalmarket/impl/dtutils/dtutils.go 74.25% <0.00%> (-2.32%) ⬇️
...etrievalmarket/impl/providerstates/provider_fsm.go 10.00% <ø> (ø)
...ievalmarket/impl/providerstates/provider_states.go 88.10% <0.00%> (-11.90%) ⬇️
...market/impl/requestvalidation/requestvalidation.go 85.97% <20.00%> (-6.76%) ⬇️
retrievalmarket/impl/clientstates/client_fsm.go 76.54% <42.86%> (-2.81%) ⬇️
retrievalmarket/types.go 45.10% <42.86%> (-0.55%) ⬇️
retrievalmarket/impl/provider_environments.go 71.43% <60.00%> (-1.45%) ⬇️
retrievalmarket/impl/client.go 71.78% <100.00%> (+0.23%) ⬆️
retrievalmarket/impl/clientstates/client_states.go 94.37% <100.00%> (+0.34%) ⬆️
retrievalmarket/impl/provider.go 76.53% <100.00%> (+1.97%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026a533...78f6b68. Read the comment docs.

@hannahhoward
Copy link
Collaborator

LGTM

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit cb4181f into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieval Provider Can Set Unseal Price
3 participants