Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade specs-actors #333

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Upgrade specs-actors #333

merged 1 commit into from
Jul 23, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Match spec actors sha in Lotus/Next

Implementation

  • upgrade deps
  • fix some cbor-gen issues
  • fix checks of nil selectors on retrieval proposals
  • change local discovery back to using cborutil -- it's super error prone vis a vis running CBOR-gen otherwise

@codecov-commenter
Copy link

Codecov Report

Merging #333 into master will increase coverage by 0.43%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   62.75%   63.18%   +0.43%     
==========================================
  Files          40       40              
  Lines        2451     2504      +53     
==========================================
+ Hits         1538     1582      +44     
- Misses        803      807       +4     
- Partials      110      115       +5     
Impacted Files Coverage Δ
...market/impl/requestvalidation/requestvalidation.go 85.97% <0.00%> (ø)
retrievalmarket/discovery/local.go 61.91% <50.00%> (ø)
retrievalmarket/impl/client.go 71.78% <100.00%> (ø)
retrievalmarket/types.go 47.17% <100.00%> (+2.08%) ⬆️
piecestore/piecestore.go 82.76% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4181f...7608540. Read the comment docs.

Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -237,6 +237,10 @@ type Params struct {
UnsealPrice abi.TokenAmount
}

func (p Params) SelectorSpecified() bool {
return p.Selector != nil && !bytes.Equal(p.Selector.Raw, cbg.CborNull)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice.

@hannahhoward hannahhoward merged commit b426fa6 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants