Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert label JSON to CBOR #393

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Convert label JSON to CBOR #393

merged 2 commits into from
Sep 6, 2020

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Sep 4, 2020

Goals

Shorten the label field by using CBOR

Implementation

Use CBOR instead of json (previously was using different options with JSON encoder to avoid whitespace)

@mikeal
Copy link

mikeal commented Sep 6, 2020

that’s a codec bug, shouldn’t even be allowed to do that.

@hannahhoward hannahhoward changed the title Fix label json to have less white space Convert label JSON to CBOR Sep 6, 2020
@hannahhoward
Copy link
Collaborator Author

@mikeal you should check in with @warpfork about that -- the default DAGJSON encoder in go-ipld-prime does whitespace

@hannahhoward
Copy link
Collaborator Author

anyway, I make this into a CBOR converter instead

@codecov-commenter
Copy link

Codecov Report

Merging #393 into master will decrease coverage by 0.05%.
The diff coverage is 62.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   61.89%   61.84%   -0.04%     
==========================================
  Files          43       43              
  Lines        2925     2971      +46     
==========================================
+ Hits         1810     1837      +27     
- Misses        964      981      +17     
- Partials      151      153       +2     
Impacted Files Coverage Δ
...etrievalmarket/impl/providerstates/provider_fsm.go 8.83% <0.00%> (-1.17%) ⬇️
retrievalmarket/types.go 42.38% <0.00%> (-4.79%) ⬇️
retrievalmarket/impl/client.go 67.46% <36.37%> (+0.79%) ⬆️
retrievalmarket/impl/clientstates/client_fsm.go 72.81% <73.92%> (-1.72%) ⬇️
retrievalmarket/impl/dtutils/dtutils.go 76.67% <75.00%> (+1.67%) ⬆️
retrievalmarket/impl/clientstates/client_states.go 92.78% <91.67%> (-1.89%) ⬇️
retrievalmarket/impl/provider.go 76.99% <100.00%> (+0.19%) ⬆️
storagemarket/impl/clientutils/clientutils.go 79.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae84f3...1c1c1f8. Read the comment docs.

@hannahhoward hannahhoward merged commit 07480b4 into master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants