Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record data transfer errors #432

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Record data transfer errors #432

merged 2 commits into from
Oct 14, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

  • Provide more information in deals about the state of disconnects

Implementation

  • in storage market, record an error when data transfer stalls
  • in retrieval market, cause we have no restarts (yet), fail when data transfer stalls

Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #432 into master will decrease coverage by 0.20%.
The diff coverage is 36.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   65.75%   65.55%   -0.19%     
==========================================
  Files          48       48              
  Lines        3252     3274      +22     
==========================================
+ Hits         2138     2146       +8     
- Misses        865      877      +12     
- Partials      249      251       +2     
Impacted Files Coverage Δ
storagemarket/impl/clientstates/client_fsm.go 86.46% <0.00%> (-4.75%) ⬇️
storagemarket/impl/providerstates/provider_fsm.go 76.20% <0.00%> (-3.80%) ⬇️
storagemarket/impl/dtutils/dtutils.go 64.71% <50.00%> (-1.96%) ⬇️
retrievalmarket/impl/dtutils/dtutils.go 78.31% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfecb0...6872046. Read the comment docs.

@hannahhoward hannahhoward merged commit ff8e64c into master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants