Disallow concurrent retrieval deals for same peer/cid #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 65.16% 65.41% +0.25%
==========================================
Files 50 51 +1
Lines 3266 3431 +165
==========================================
+ Hits 2128 2244 +116
- Misses 912 958 +46
- Partials 226 229 +3
Continue to review full report at Codecov.
|
dirkmc
force-pushed
the
fix/dup-retr-deal
branch
3 times, most recently
from
c4c8c15
to
f9e8df5
Compare
dirkmc
force-pushed
the
fix/dup-retr-deal
branch
from
f9e8df5
to
5f11ad2
Compare
dirkmc
force-pushed
the
fix/dup-retr-deal
branch
from
5f11ad2
to
ea7b41d
Compare
raulk
reviewed
Feb 25, 2021
| @@ -281,6 +296,31 @@ func (c *Client) Retrieve(ctx context.Context, payloadCID cid.Cid, params retrie | |||
| return dealID, nil | |||
| } | |||
|
|
|||
| // Check if there's already an active retrieval deal with the same peer | |||
| // for the same payload CID | |||
| func (c *Client) checkForActiveDeal(payloadCID cid.Cid, pid peer.ID) error { | |||
There was a problem hiding this comment.
nit: It would be more idiomatic to return (dealID, bool) here, and create the error in the caller.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses filecoin-project/lotus#5443