Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout for sending cancel message to peer when retrieval cancelled #531

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Apr 2, 2021

No description provided.

if testCase.failsUnseal {
assert.Equal(t, retrievalmarket.DealStatusErrored, clientDealState.Status)
} else if testCase.cancelled {
if testCase.failsUnseal || testCase.cancelled {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's an error unsealing on the provider, the best we can hope for on the client side is to receive a cancel message.
This test only passed before because the statemachine on the client was already shutdown when it received the Cancel event, so firing the event caused an error.
I fixed that bug so that the statemachine just ignores a Cancel event when the statemachine has already been shutdown

@codecov-io
Copy link

Codecov Report

Merging #531 (8fb8e7c) into master (ccf567f) will decrease coverage by 0.11%.
The diff coverage is 34.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   65.65%   65.54%   -0.10%     
==========================================
  Files          52       53       +1     
  Lines        3534     3549      +15     
==========================================
+ Hits         2320     2326       +6     
- Misses        983      990       +7     
- Partials      231      233       +2     
Impacted Files Coverage Δ
retrievalmarket/impl/dtutils/dtutils.go 79.44% <0.00%> (ø)
shared/close.go 0.00% <0.00%> (ø)
storagemarket/impl/dtutils/dtutils.go 75.00% <0.00%> (ø)
retrievalmarket/impl/client.go 70.05% <50.00%> (-0.90%) ⬇️
retrievalmarket/impl/provider_environments.go 55.43% <50.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf567f...8fb8e7c. Read the comment docs.

@dirkmc dirkmc merged commit ff7bf5a into master Apr 2, 2021
@dirkmc dirkmc deleted the fix/retrieval-close-timout branch April 2, 2021 13:17
@dirkmc dirkmc mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants