Skip to content

Call stageDone on nil nextStep #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

Call stageDone on nil nextStep #7

merged 2 commits into from
Mar 3, 2020

Conversation

hannahhoward
Copy link
Contributor

Goal

Fix a bug where:

  • 2 events are in queue
  • 1 processed
  • nextStep is nil
  • never executes processing next event if no additional events arrive

Implementation

  • need to write to stageDone channel
  • at this point, easiest to just put conditional for nil nextStep inside goroutine

@hannahhoward
fix(statemachine): note stage done on nil step
2074af6 
so that a handler with a nil step will still process further events if blocked, write to stagedone
@hannahhoward
test(statemachine): add test to verify fix
31a378c
ingar
ingar approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nil checks. 👍

@hannahhoward hannahhoward merged commit f2f9516 into master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ingar ingar ingar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannahhoward @ingar