Add daemon command #52
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
===========================================
- Coverage 58.28% 46.78% -11.51%
===========================================
Files 20 27 +7
Lines 2069 2302 +233
===========================================
- Hits 1206 1077 -129
- Misses 829 1189 +360
- Partials 34 36 +2
|
| func versionCommand(cctx *cli.Context) error { | ||
| if version == "" { | ||
| log.Warn("executable built without a version") | ||
| log.Warn("set version with `go build -ldflags=\"-X main.version=v0.0.0\"") |
There was a problem hiding this comment.
do we need to adapt our release build github workflow to do this?
There was a problem hiding this comment.
Yes, I was meaning to look into that and haven't yet. Ideally we have that build flag use the version.json to set that value.
kylehuntsman
force-pushed
the
feat/http-server
branch
2 times, most recently
from
af88596
to
7695126
Compare
kylehuntsman
force-pushed
the
feat/http-server
branch
3 times, most recently
from
fb9a511
to
6687eca
Compare
|
The server now instantiates a Lassie that is passed to the
|
kylehuntsman
force-pushed
the
feat/http-server
branch
from
6687eca
to
e2019b7
Compare
| res.Header().Set("Cache-Control", "public, max-age=29030400, immutable") | ||
| res.Header().Set("Content-Type", "application/vnd.ipld.car; version=1") | ||
| res.Header().Set("Etag", fmt.Sprintf("%s.car", rootCid.String())) | ||
| res.Header().Set("C-Content-Type-Options", "nosniff") |
| res.Header().Set("X-Ipfs-Path", req.URL.Path) | ||
| // TODO: set X-Ipfs-Roots header |
There was a problem hiding this comment.
💭 fwiw these two make sense mostly in deserialized contexts like website hosting: allow for partial HTTP Cache invalidation based on DAG/path subset that changed (ipfs/kubo#8720, based on request from Cloudflare)
For requests for /ipfs/cid without any sub path they don't bring much value ( Etag is more than enough).
So fine to skip X-Ipfs-Roots header until you support sub-paths (if its even planned)
Adds a
lassie daemoncommand for running an http server. Some things are not very pretty, but the HTTP interface should be okay to use while we clean up everything behind.Notable Changes:
daemoncommand that starts a running http serverversioncommand for logging the version. lassie needs to be built with-ldflags="main.version=v0.0.0"to set the version.-vand-vvverbose flags for additional logging/ipfsendpoint that implements issue HTTP Daemon #34Notes:
Lassieobject that you can callFetchon. Makes a nicelassie.Fetch()call.application/vnd.ipld.car(including wildcard types), the request is accepted.formatquery parameter is provided but is not the valuecar, the server responds with a 400.filenamequery parameter value extension is not.car, the server responds with a 400.Known TODOs: