Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chaineconomics: add FilReserveDisbursed #462

Closed
hsanjuan opened this issue Apr 12, 2021 · 2 comments · Fixed by #528
Closed

Chaineconomics: add FilReserveDisbursed #462

hsanjuan opened this issue Apr 12, 2021 · 2 comments · Fixed by #528
Assignees
@iand

Comments

@hsanjuan
Copy link
Contributor

Description

The chain economics table does not track FilReserveDisbursed.

This is used for calculating FIL circulating_fil but apparently not exposed by the CirculatingSupply object.

Where to begin

Guess this was added recently, probably should PR to Lotus so it is exposed by that supply object.
@frrist frrist self-assigned this Apr 16, 2021
frrist added a commit to filecoin-project/lotus that referenced this issue Apr 16, 2021
@frrist
polish(api): expose filReserveDisbursed via CirculatingSupply API
c118415 
- motivated by: filecoin-project/lily#462
@frrist frrist mentioned this issue Apr 16, 2021
Merged
@frrist
Copy link
Member

frrist commented Apr 16, 2021

Lotus PR here, will pull in and update visor once it merges: filecoin-project/lotus#6059

@hsanjuan hsanjuan added this to the Schema-related issues before full backfill milestone Apr 28, 2021
@iand iand assigned iand and unassigned frrist May 27, 2021
@iand
Copy link
Contributor

iand commented May 27, 2021

isn't it odd that reserve disbursed is not mentioned in the calculation of circulating supply on https://spec.filecoin.io/#section-systems.filecoin_token.token_allocation? I assume it's included in Fil_Mined but that term is not defined.

@iand iand mentioned this issue May 27, 2021
Merged
@iand iand closed this as completed in #528 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iand iand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add v1 schema filecoin-project/lily
3 participants
@iand @hsanjuan @frrist