feat: track verifreg actor claim HAMT changes #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frrist
commented
Feb 22, 2023
frrist
commented
- request made here: https://github.com/protocol/pldw/issues/177#issuecomment-1372920524
frrist
force-pushed
the
frrist/track-verifreg-claims
branch
from
7c10e7e to
42115c7
Compare
kasteph
reviewed
Feb 27, 2023
schemas/v1/17_verifreg_claims.go
Outdated
| sector BIGINT NOT NULL, | ||
| event {{ .SchemaName | default "public"}}.verified_registry_event_type NOT NULL, | ||
|
|
||
| PRIMARY KEY(height, state_root, provider, claim_id) |
There was a problem hiding this comment.
Could a claim_id be the same for different providers? If not, perhaps the PRIMARY KEY could be simplified to the following:
PRIMARY KEY(height, state_root, claim_id
to make it faster.
There was a problem hiding this comment.
@anorth or @ZenGround0 as authors of FIP-45 could you either of you comment on the uniqueness of ClaimIDs? Are they globally unique (like DealIDs) or unique per provider (like sectorIDs to miners)? The FIP doesn't seem to specify this, or I can't find where it does, at least.
There was a problem hiding this comment.
@ZenGround0 and I looked at the in the office together, and the answer is: ClaimID is a globally unique ID meaning I should (and will) change the PK definition not to include the provider in the constraint.
Terryhung
pushed a commit
that referenced
this pull request
Mar 3, 2023
* feat: track verified registry actor claim HAMT changes - addresses request made here: https://github.com/protocol/pldw/issues/177#issuecomment-1372920524
birdychang
pushed a commit
that referenced
this pull request
Mar 8, 2023
* deps: update to lotus 1.20.0-rc2 * chore: update actor gen - clean up types, remove lily actors types, replace with go-state-types * Frrist/receipt events schema (#1132) * feat: implement actor event task and schema - track the value of EventRoots contained in message receipts. * feat: implement message param schema and task - create a table that records raw message parameters * feat: track raw receipt return value * fix schema index's after rebase on master * fix: use builtin lotus method to get events - it handles the case of legacy events * fixup! Frrist/receipt events schema (#1132) * deps: replace deprecated blocks package - use github.com/ipfs/go-libipfs/blocks instead * deps: update to v1.20.0 release * feat: track verifreg actor claim HAMT changes (#1141) * feat: track verified registry actor claim HAMT changes - addresses request made here: https://github.com/protocol/pldw/issues/177#issuecomment-1372920524 * fix: correctly diff new actor version (#1145) * fix: correctly diff new actor version - closes #1144 * chore: remove unused metrics * metric: track GettActorStateChanges duration * feat: update lotus deps to support vm para/ret marshal (#1150) - use lotus deps from filecoin-project/lotus#10372 * fix: resolve the duplication issue of db migration version --------- Co-authored-by: Terry <terry@TerrydeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.