Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing #335

Merged
merged 3 commits into from
Jun 1, 2021
Merged

tracing #335

merged 3 commits into from
Jun 1, 2021

Conversation

coryschwartz
Copy link

No description provided.

@coryschwartz
Copy link
Author

@coryschwartz coryschwartz marked this pull request as ready for review May 27, 2021 01:35
@coryschwartz
Copy link
Author

coryschwartz commented May 27, 2021

This is...kind-of enabled on a node already, however not using filecoin-project/lotus#6323. Instead, I have this abominaion installed to construct the LOTUS_JAEGER env variable.

    spec:
      containers:
      - args:
        - LOTUS_JAEGER="${LOTUS_JAEGER_AGENT_HOST}:${LOTUS_JAEGER_AGENT_PORT}" /usr/local/bin/lotus daemon
        command:
        - bash
        - -c

So long as filecoin-project/lotus#6323 is merged, this silly bash -c encantation can be avoided, since lotus will read from these environment variables directly.

If you have a look at logz.io you can see a few there.

@coryschwartz coryschwartz merged commit 7ac31e5 into master Jun 1, 2021
@GlacierWalrus GlacierWalrus deleted the feat/tracing branch May 1, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant