changes as per review

filecoin-project · Mar 26, 2021 · 3ece9d7 · 3ece9d7
1 parent abcf4c7
commit 3ece9d7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/cli/client.go b/cli/client.go
@@ -1552,9 +1552,9 @@ var clientListDeals = &cli.Command{
 			DefaultText: "no-op",
 		},
 		&cli.IntFlag{
-			Name:        "deals-per-page",
-			Usage:       "number of deals to show in the deal list page",
-			DefaultText: "defaults to all deals that match the given criteria",
+			Name:  "limit",
+			Usage: "number of deals to show in the deal list page",
+			Value: 50,
 		},
 		&cli.Int64Flag{
 			Name:        "min-start-epoch",
@@ -1580,7 +1580,7 @@ var clientListDeals = &cli.Command{
 		watch := cctx.Bool("watch")
 
 		ctOffset := cctx.Int64("creation-time-offset")
-		nDeals := cctx.Int("deals-per-page")
+		nDeals := cctx.Int("limit")
 		minStart := cctx.Int64("min-start-epoch")
 		maxEnd := cctx.Int64("max-end-epoch")
 		hideFailed := cctx.Bool("hide-failed")
@@ -1608,7 +1608,7 @@ var clientListDeals = &cli.Command{
 				tm.Clear()
 				tm.MoveCursor(1, 1)
 
-				err = outputStorageDeals(ctx, tm.Screen, api, localDeals, verbose, color, showFailed)
+				err = outputStorageDeals(ctx, tm.Screen, api, localDeals, verbose, color, !hideFailed)
 				if err != nil {
 					return err
 				}
@@ -1634,7 +1634,7 @@ var clientListDeals = &cli.Command{
 			}
 		}
 
-		return outputStorageDeals(ctx, cctx.App.Writer, api, localDeals, verbose, color, showFailed)
+		return outputStorageDeals(ctx, cctx.App.Writer, api, localDeals, verbose, color, !hideFailed)
 	},
 }
 

diff --git a/go.mod b/go.mod
@@ -34,7 +34,7 @@ require (
 	github.com/filecoin-project/go-crypto v0.0.0-20191218222705-effae4ea9f03
 	github.com/filecoin-project/go-data-transfer v1.4.0
 	github.com/filecoin-project/go-fil-commcid v0.0.0-20201016201715-d41df56b4f6a
-	github.com/filecoin-project/go-fil-markets v1.2.3
+	github.com/filecoin-project/go-fil-markets v1.0.8-0.20210325080341-82f614c26d93
 	github.com/filecoin-project/go-jsonrpc v0.1.4-0.20210217175800-45ea43ac2bec
 	github.com/filecoin-project/go-multistore v0.0.3
 	github.com/filecoin-project/go-padreader v0.0.0-20200903213702-ed5fae088b20

diff --git a/go.sum b/go.sum
@@ -273,6 +273,8 @@ github.com/filecoin-project/go-fil-commcid v0.0.0-20200716160307-8f644712406f/go
 github.com/filecoin-project/go-fil-commcid v0.0.0-20201016201715-d41df56b4f6a h1:hyJ+pUm/4U4RdEZBlg6k8Ma4rDiuvqyGpoICXAxwsTg=
 github.com/filecoin-project/go-fil-commcid v0.0.0-20201016201715-d41df56b4f6a/go.mod h1:Eaox7Hvus1JgPrL5+M3+h7aSPHc0cVqpSxA+TxIEpZQ=
 github.com/filecoin-project/go-fil-markets v1.0.5-0.20201113164554-c5eba40d5335/go.mod h1:AJySOJC00JRWEZzRG2KsfUnqEf5ITXxeX09BE9N4f9c=
+github.com/filecoin-project/go-fil-markets v1.0.8-0.20210325080341-82f614c26d93 h1:narSwEt79rz2G3KCDwOirr1sGPQ1wA1gLKxX1I/qW0w=
+github.com/filecoin-project/go-fil-markets v1.0.8-0.20210325080341-82f614c26d93/go.mod h1:p5BIKl6sEoeOCKFa3/nfy66Q95rifEkJyGQgaNjPsno=
 github.com/filecoin-project/go-fil-markets v1.2.3 h1:JDbGKQf60tB00TFKG/nofSyHyIEbqowZqoLOfda7yTs=
 github.com/filecoin-project/go-fil-markets v1.2.3/go.mod h1:p5BIKl6sEoeOCKFa3/nfy66Q95rifEkJyGQgaNjPsno=
 github.com/filecoin-project/go-hamt-ipld v0.1.5 h1:uoXrKbCQZ49OHpsTCkrThPNelC4W3LPEk0OrS/ytIBM=