Skip to content

Commit

Permalink
feat(conformance): skip incorrect tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Alan Shaw committed Aug 26, 2020
1 parent a03931d commit 6c5d012
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
5 changes: 2 additions & 3 deletions conformance/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,10 @@ func (d *Driver) ExecuteMessage(msg *types.Message, preroot cid.Cid, bs blocksto
invoker := vm.NewInvoker()

// add support for the puppet and chaos actors.
selector := d.vector.Selector.Unpack()
if puppetOn, ok := selector["puppet_actor"]; ok && puppetOn == "true" {
if puppetOn, ok := d.vector.Selector["puppet_actor"]; ok && puppetOn == "true" {
invoker.Register(puppet.PuppetActorCodeID, puppet.Actor{}, puppet.State{})
}
if chaosOn, ok := selector["chaos_actor"]; ok && chaosOn == "true" {
if chaosOn, ok := d.vector.Selector["chaos_actor"]; ok && chaosOn == "true" {
invoker.Register(chaos.ChaosActorCodeCID, chaos.Actor{}, chaos.State{})
}

Expand Down
7 changes: 7 additions & 0 deletions conformance/runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ func TestConformance(t *testing.T) {
}

t.Run(v, func(t *testing.T) {
for _, h := range vector.Hints {
if h == schema.HintIncorrect {
t.Logf("skipping vector marked as incorrect: %s", vector.Meta.ID)
t.SkipNow()
}
}

// dispatch the execution depending on the vector class.
switch vector.Class {
case "message":
Expand Down
2 changes: 1 addition & 1 deletion extern/test-vectors
Submodule test-vectors updated 90 files
+65 −0 .github/workflows/generate-test-vectors.yaml
+8 −2 Makefile
+84 −2 README.md
+37 −1 chaos/actor.go
+112 −0 chaos/cbor_gen.go
+1 −1 chaos/gen/gen.go
+10 −6 corpus/actor_creation/addresses--sequential-10.json
+10 −6 corpus/actor_creation/on_transfer--fail-bls-insufficient-balance.json
+10 −6 corpus/actor_creation/on_transfer--fail-secp256k1-insufficient-balance.json
+10 −6 corpus/actor_creation/on_transfer--ok-create-bls.json
+10 −6 corpus/actor_creation/on_transfer--ok-create-secp256k1.json
+60 −0 corpus/actor_creation/x--params--fails-unparsable-constructor-params-via-init-actor.json
+60 −0 corpus/actor_creation/x--params--fails-unparsable-init-actor-exec-msg.json
+10 −6 corpus/msg_application/actor_exec--msg-apply-fail-actor-execution-illegal-arg.json
+10 −6 corpus/msg_application/gas_cost--msg-apply-fail-onchainsize-gas.json
+10 −6 corpus/msg_application/gas_cost--msg-apply-fail-receipt-gas.json
+10 −6 corpus/msg_application/gas_cost--msg-apply-fail-transfer-accountcreation-gas.json
+10 −6 corpus/msg_application/invalid_msgs--msg-apply-fail-invalid-nonce.json
+10 −6 corpus/msg_application/invalid_msgs--msg-apply-fail-invalid-receiver-method.json
+10 −6 corpus/msg_application/unknown_actors--msg-apply-fail-unknown-receiver.json
+10 −6 corpus/msg_application/unknown_actors--msg-apply-fail-unknown-sender.json
+10 −6 corpus/multisig/basic--ok-add-signer.json
+10 −6 corpus/multisig/basic--ok-create.json
+10 −6 corpus/multisig/basic--ok-propose-and-approve.json
+10 −6 corpus/multisig/basic--ok-propose-and-cancel.json
+10 −6 corpus/nested/nested_sends--fail-aborted-exec.json
+10 −6 corpus/nested/nested_sends--fail-inner-abort.json
+13 −6 corpus/nested/nested_sends--fail-insufficient-funds-for-transfer-in-inner-send.json
+10 −6 corpus/nested/nested_sends--fail-invalid-method-num-for-actor.json
+10 −6 corpus/nested/nested_sends--fail-invalid-method-num-new-actor.json
+10 −6 corpus/nested/nested_sends--fail-mismatch-params.json
+10 −6 corpus/nested/nested_sends--fail-missing-params.json
+10 −6 corpus/nested/nested_sends--fail-non-existent-actor-address.json
+10 −6 corpus/nested/nested_sends--fail-non-existent-id-address.json
+10 −6 corpus/nested/nested_sends--ok-basic.json
+10 −6 corpus/nested/nested_sends--ok-non-cbor-params-with-transfer.json
+10 −6 corpus/nested/nested_sends--ok-recursive.json
+10 −6 corpus/nested/nested_sends--ok-to-new-actor-with-invoke.json
+10 −6 corpus/nested/nested_sends--ok-to-new-actor.json
+10 −6 corpus/paych/paych--collect-ok.json
+10 −6 corpus/paych/paych--create-ok.json
+10 −6 corpus/paych/paych--update-ok.json
+10 −6 corpus/transfer/basic--fail-balance-equal-gas.json
+10 −6 corpus/transfer/basic--fail-balance-under-gaslimit.json
+10 −6 corpus/transfer/basic--fail-exceed-balance.json
+10 −6 corpus/transfer/basic--fail-negative-amount.json
+10 −6 corpus/transfer/basic--ok-zero.json
+10 −6 corpus/transfer/basic--ok.json
+10 −6 corpus/transfer/self_transfer--id-to-id-addresses.json
+10 −6 corpus/transfer/self_transfer--id-to-secp-addresses.json
+10 −6 corpus/transfer/self_transfer--secp-to-id-addresses.json
+10 −6 corpus/transfer/self_transfer--secp-to-secp-addresses.json
+55 −0 corpus/transfer/system_receiver--to-burnt-funds-actor.json
+55 −0 corpus/transfer/system_receiver--to-cron-actor.json
+55 −0 corpus/transfer/system_receiver--to-init-actor.json
+55 −0 corpus/transfer/system_receiver--to-reward-actor.json
+55 −0 corpus/transfer/system_receiver--to-storage-market-actor.json
+55 −0 corpus/transfer/system_receiver--to-storage-power-actor.json
+55 −0 corpus/transfer/system_receiver--to-system-actor.json
+55 −0 corpus/transfer/system_receiver--to-verified-registry-actor.json
+10 −6 corpus/transfer/unknown_accounts--fail-unknown-sender-known-receiver.json
+10 −6 corpus/transfer/unknown_accounts--fail-unknown-sender-unknown-receiver.json
+0 −50 corpus/transfer/unknown_accounts--id-to-id-addresses.json
+0 −50 corpus/transfer/unknown_accounts--id-to-secp-addresses.json
+0 −50 corpus/transfer/unknown_accounts--secp-to-id-addresses.json
+58 −0 corpus/vm_violations/actor_creation--control-ok-with-good-address-good-cid.json
+58 −0 corpus/vm_violations/actor_creation--fails-with-existing-address.json
+58 −0 corpus/vm_violations/actor_creation--fails-with-good-addr-undef-cid.json
+58 −0 corpus/vm_violations/actor_creation--fails-with-undef-actor-cid-undef-addr.json
+58 −0 corpus/vm_violations/actor_creation--fails-with-unknown-actor-cid-undef-addr.json
+58 −0 corpus/vm_violations/actor_creation--fails-with-unknown-actor-cid.json
+58 −0 corpus/vm_violations/caller_validation--nil-allowed-address-set.json
+58 −0 corpus/vm_violations/caller_validation--nil-allowed-type-set.json
+58 −0 corpus/vm_violations/caller_validation--none.json
+58 −0 corpus/vm_violations/caller_validation--twice.json
+9 −0 gen/builders/address.go
+14 −3 gen/builders/asserter.go
+26 −4 gen/builders/builder.go
+21 −1 gen/builders/diagnostics.go
+186 −26 gen/builders/generator.go
+15 −2 gen/builders/state_zero.go
+25 −1 gen/suites/actor_creation/main.go
+65 −0 gen/suites/actor_creation/params.go
+2 −1 gen/suites/nested/main.go
+40 −21 gen/suites/transfer/main.go
+58 −0 gen/suites/transfer/system_receiver.go
+47 −0 gen/suites/vm_violations/actor_creation.go
+96 −4 gen/suites/vm_violations/main.go
+34 −6 schema.json
+27 −23 schema/schema.go

0 comments on commit 6c5d012

Please sign in to comment.