fix: unsafe append in LoadTipSet

filecoin-project · Sep 28, 2020 · cc45aba · cc45aba
1 parent 6b16d48
commit cc45aba
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/chain/store/store.go b/chain/store/store.go
@@ -473,15 +473,15 @@ func (cs *ChainStore) LoadTipSet(tsk types.TipSetKey) (*types.TipSet, error) {
 	var eg errgroup.Group
 	cids := tsk.Cids()
 	blks := make([]*types.BlockHeader, 0, len(cids))
-	for _, c := range cids {
-		c := c
+	for i, c := range cids {
+		i, c := i, c
 		eg.Go(func() error {
 			b, err := cs.GetBlock(c)
 			if err != nil {
 				return xerrors.Errorf("get block %s: %w", c, err)
 			}
 
-			blks = append(blks, b)
+			blks[i] = b
 			return nil
 		})
 	}