Skip to content

Commit

Permalink
fix: review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@Stebalien
Stebalien committed Mar 1, 2023
1 parent db5d9f3 commit dc0929e
Show file tree
Hide file tree
Showing 6 changed files with 50 additions and 50 deletions.
Binary file modified build/openrpc/full.json.gz
View file
Binary file not shown.
16 changes: 8 additions & 8 deletions chain/types/cbor_gen.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions chain/types/execresult.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ type GasTrace struct {
}

type MessageTrace struct {
From address.Address
To address.Address
Value abi.TokenAmount
Method abi.MethodNum
Params []byte
Codec uint64
From address.Address
To address.Address
Value abi.TokenAmount
Method abi.MethodNum
Params []byte
ParamsCodec uint64
}

type ReturnTrace struct {
ExitCode exitcode.ExitCode
Return []byte
Codec uint64
ExitCode exitcode.ExitCode
Return []byte
ReturnCodec uint64
}

type ExecutionTrace struct {
Expand Down
18 changes: 9 additions & 9 deletions chain/vm/vm.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ func (vm *LegacyVM) makeRuntime(ctx context.Context, msg *types.Message, parent
allowInternal: true,
callerValidated: false,
executionTrace: types.ExecutionTrace{Msg: types.MessageTrace{
From: msg.From,
To: msg.To,
Value: msg.Value,
Method: msg.Method,
Params: msg.Params,
Codec: paramsCodec,
From: msg.From,
To: msg.To,
Value: msg.Value,
Method: msg.Method,
Params: msg.Params,
ParamsCodec: paramsCodec,
}},
}

Expand Down Expand Up @@ -386,9 +386,9 @@ func (vm *LegacyVM) send(ctx context.Context, msg *types.Message, parent *Runtim
retCodec = CborCodec
}
rt.executionTrace.MsgRct = types.ReturnTrace{
ExitCode: aerrors.RetCode(err),
Return: ret,
Codec: retCodec,
ExitCode: aerrors.RetCode(err),
Return: ret,
ReturnCodec: retCodec,
}

return ret, err, rt
Expand Down
24 changes: 12 additions & 12 deletions documentation/en/api-v0-methods.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4871,12 +4871,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -4895,12 +4895,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down Expand Up @@ -5101,12 +5101,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -5125,12 +5125,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down Expand Up @@ -6487,12 +6487,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -6511,12 +6511,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down
24 changes: 12 additions & 12 deletions documentation/en/api-v1-unstable-methods.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6186,12 +6186,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -6210,12 +6210,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down Expand Up @@ -6416,12 +6416,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -6440,12 +6440,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down Expand Up @@ -7885,12 +7885,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand All @@ -7909,12 +7909,12 @@ Response:
"Value": "0",
"Method": 1,
"Params": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ParamsCodec": 42
},
"MsgRct": {
"ExitCode": 0,
"Return": "Ynl0ZSBhcnJheQ==",
"Codec": 42
"ReturnCodec": 42
},
"GasCharges": [
{
Expand Down

0 comments on commit dc0929e

Please sign in to comment.