-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaxCommitBatch/ MaxPreCommitBatch is too high #10612
Comments
Yes, I think it's time we do this. In addition to "making more sense", I think it's a good idea to have fewer messages taking up (potentially) an entire gas block limit. I think as protocol designers we want such messages to be rare (though they'll always be possible with the FEVM). |
Would suggest creating a separate actors issue for the first point. |
Its difficult to reliably get a sensible upper bound for what each of these limits needs to be since gas fees for these messages depends not only on the messages themselves but on the actor state as well, leading to a high variance in the number of sectors that can be aggregated per message My proposal is to simulate PCA/PCB with a StateCall and if we see that the message requires more gas than the block limit, split the batch into 2 and try again continuously until we arrive at a batch size that works For ProveCommitAggregate, this means calculating the aggregate proofs multiple times. Talking to @magik6k, this should be cheap enough to do |
A couple protocol changes have resulted in PCB and PCA gas usage increase:
That being said, if user creates messages with the previous MaxPreCommitBatch (256) and MaxCommitBatch (819) - the message likely will fail due to
message execution failed: exit SysErrOutOfGas
as the block limit has reached.its similar with #8986 #8982, however, again with higher impact from fip0045
we should
The text was updated successfully, but these errors were encountered: