-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EthTxHashLookup has poor query management #12171
Comments
Can also be a good issue for Mikers |
rvagg
added a commit
that referenced
this issue
Jul 15, 2024
rvagg
added a commit
that referenced
this issue
Jul 15, 2024
rvagg
added a commit
that referenced
this issue
Jul 15, 2024
rvagg
added a commit
that referenced
this issue
Jul 16, 2024
ribasushi
pushed a commit
to ribasushi/ltsh
that referenced
this issue
Jul 16, 2024
ribasushi
pushed a commit
to ribasushi/ltsh
that referenced
this issue
Jul 16, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Jul 17, 2024
ribasushi
pushed a commit
to ribasushi/ltsh
that referenced
this issue
Jul 24, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Jul 24, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Aug 17, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Aug 20, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed in a heap dump:
EthTxHashLookup#UpsertHash
creates a new PreparedStatement on each call and then does nothing else with it (probably should be closed at a minimum). The remainder of the queries don't use PreparedStatements at all.TODO:
EthTxHashLookup
for re-useShould be done after #12098 is merged, or done on top of that branch.
The text was updated successfully, but these errors were encountered: