Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthTxHashLookup has poor query management #12171

Closed
rvagg opened this issue Jul 2, 2024 · 1 comment · Fixed by #12235
Closed

EthTxHashLookup has poor query management #12171

rvagg opened this issue Jul 2, 2024 · 1 comment · Fixed by #12235
Assignees

Comments

@rvagg
Copy link
Member

rvagg commented Jul 2, 2024

Noticed in a heap dump:

Screenshot 2024-07-02 at 9 57 56 AM

EthTxHashLookup#UpsertHash creates a new PreparedStatement on each call and then does nothing else with it (probably should be closed at a minimum). The remainder of the queries don't use PreparedStatements at all.

TODO:

  • Refactor to use PreparedStatements for all queries not involved in migration
  • Retain PreparedStatement instances on the parent EthTxHashLookup for re-use

Should be done after #12098 is merged, or done on top of that branch.

@rvagg rvagg self-assigned this Jul 2, 2024
@jennijuju
Copy link
Member

Can also be a good issue for Mikers

@rvagg rvagg closed this as completed in 1c05985 Jul 16, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this issue Jul 17, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this issue Jul 24, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this issue Aug 17, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this issue Aug 20, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants