Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage-deal maximum piece size set to 1MiB upon miner restart #4458

Closed
stuberman opened this issue Oct 18, 2020 · 8 comments
Closed

storage-deal maximum piece size set to 1MiB upon miner restart #4458

stuberman opened this issue Oct 18, 2020 · 8 comments

Comments

@stuberman
Copy link

Describe the bug
Since v0.10.2 when the lotus-miner restarts the maximum storage-deal piece size is set to 1MiB

To Reproduce

  1. Run 'lotus-miner run'
  2. See lotus-miner storage-deals get-ask
  3. max-piece-size reset to 1MiB

Expected behavior
Expect former state (--max-piece-size 32GiB) to remain intact and not change to 1MiB

Screenshots
lotus-miner storage-deals get-ask
Price per GiB/Epoch Verified Min. Piece Size (padded) Max. Piece Size (padded) Expiry (Epoch) Expiry (Appx. Rem. Time) Seq. No.
0.000000002 FIL 0.0000000005 FIL 100 KiB 1 MiB 241345 710h55m0s 37

Version (run lotus version):
Daemon: 0.10.2+git.8bb84acb+api0.15.0
Local: lotus-miner version 0.10.2+git.8bb84acb

Additional context
Only appeared from v0.10.2 - after deal duration option was removed

@kernelogic
Copy link

1MB?!!

@hsanjuan
Copy link
Contributor

@magik6k maybe you do want to take #4334, given #4384 did not fix it.

@William8Work
Copy link

got the same problem:

2020-10-18T21:04:09.830-0700 WARN providerstates providerstates/provider_states.go:501 deal bafyreicoyg64r4od6vw6boxzvvmz66v2vfza6n35awu6i4uo5uloso2wuu failed: deal rejected: piece size more than maximum allowed size: 134217728 > 1048576

@CD-oursoft
Copy link

Use the command:lotus-miner storage-deals set-ask --price=0.0000000005FIL --verified-price=0.00000000005FIL --min-piece-size=256B --max-piece-size=32GiB ,Can solve your problem

@stuberman
Copy link
Author

Manually setting the prices does not fix the problem - the problem is that when you restart the miner the maximum prices changes to 1MiB.

@stuberman
Copy link
Author

Same issue as reported here: 4440

@pooja
Copy link
Contributor

pooja commented Oct 21, 2020

@stuberman Did #4480 fix this issue?

@stuberman
Copy link
Author

Yes! Works great now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants