Fix ask Max and Min piece size being reset on reboot #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
`set-ask` for max and min piece sizes only takes effects while the miner runs. During reboot they are reset to the defaults. This is because during initialization the miner does a "default set ask" with the purpose of adjusting the MaxPieceSize to the miners sector-size. However this should only happen if the miner has never adjusted the ask themselves, that is, SeqNo is 0. Additionally, handle the case when the ask is nil, in case markets code decides to not create a default ask during initialization at some point.
hsanjuan
force-pushed
the
fix/min-piece-size-reset
branch
from
a50913c
to
ca79466
Compare
magik6k
approved these changes
Oct 12, 2020
whyrusleeping
approved these changes
Oct 12, 2020
|
More correct fix in #4384 |
|
Doesn't account for the but ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-askfor max and min piece sizes only takes effects while the minerruns. During reboot they are reset to the defaults.
This is because during initialization the miner does a "default set ask" with
the purpose of adjusting the MaxPieceSize to the miners sector-size.
However this should only happen if the miner has never adjusted the ask
themselves, that is, SeqNo is 0.
Additionally, handle the case when the ask is nil, in case markets code
decides to not create a default ask during initialization at some point.