Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling a transfer when the network connection is down fails to error out deal #5115

Closed
dirkmc opened this issue Dec 4, 2020 · 1 comment
Labels

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Dec 4, 2020

When the user cancels a transfer, it should also cancel the deal, even if the network connection is down.

In practice this does not appear to work. This deal was stuck in StorageDealTransferring:

$ lotus client list-transfers --show-failed| grep b5u
1516  Failed              ...ZGZVb4n8  ...hxjqfjqe  Y           3.317GiB     ...powhddwso2egkkuxariixvqvtpqbgtvb5u"}}  

$ lotus client cancel-transfer 1516
ERROR: unable to send cancel to channel FSM: %!w(<nil>)

$ lotus client list-transfers --show-failed| grep b5u
1516  Failed              ...ZGZVb4n8  ...hxjqfjqe  Y           3.317GiB     ...powhddwso2egkkuxariixvqvtpqbgtvb5u"}}  

$ lotus client list-deals | grep b5u
...qbgtvb5u  0        f022352   StorageDealClientTransferRestart  N                 N         ...wto77qaa  7.938 GiB  0.0004172624 FIL          521578    false
@dirkmc dirkmc added the area/markets Area: Markets label Dec 4, 2020
@jennijuju jennijuju added area/data-transfer area/ux Area: UX kind/enhancement Kind: Enhancement and removed area/markets Area: Markets labels Feb 11, 2021
@jennijuju jennijuju added this to the 💹Storage Deal Success milestone Feb 11, 2021
@dirkmc
Copy link
Contributor Author

dirkmc commented Feb 11, 2021

Fixed by #5032

@dirkmc dirkmc closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants