Cancel transfer cancels storage deal #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
Fixes #5062 (the fix is included in the go-fil-markets release included in this PR) |
magik6k
approved these changes
Dec 1, 2020
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports filecoin-project/go-fil-markets#457
When the user cancels a data transfer using the CLI, the local node
Before, if sending a "cancel" message to the remote node failed, the transfer wouldn't be cancelled locally.
Now it will be, and the deal will be failed.
This PR also adds a
cancel-timeoutparameter to bothlotus client cancel-transferandlotus-miner data-transfers cancel(by default 5s)