Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testground tests #6023

Closed
magik6k opened this issue Apr 12, 2021 · 4 comments
Closed

Fix testground tests #6023

magik6k opened this issue Apr 12, 2021 · 4 comments
Assignees
Labels
impact/test-flakiness Impact: Test Flakiness P1 P1: Must be resolved

Comments

@magik6k
Copy link
Contributor

magik6k commented Apr 12, 2021

It looks like they are failing (This is blocking #5887)

@jennijuju jennijuju added the impact/test-flakiness Impact: Test Flakiness label Apr 19, 2021
@jennijuju jennijuju added the P1 P1: Must be resolved label Apr 19, 2021
@nonsense
Copy link
Member

nonsense commented Apr 28, 2021

Lotus deals end-to-end test is working fine, however if there is a high concurrency of deals to a single miner, we are hitting Lotus bugs, that are still not resolved. We'll decide with @dirkmc how to continue, and I will file an issue later on.

For now on, in order to move forward with enabling Testground tests as part of the Lotus release cycle, we could review/merge #6122 which fixes the deals end-to-end test plan to not hit the concurrency issues.

@jennijuju
Copy link
Member

@nonsense could you please create a new issue as mentioned above and close this one?

@BlocksOnAChain
Copy link
Contributor

@nonsense Since https://github.com/filecoin-project/lotus/pull/6122 is now merged, can we deal with this issue since I believe it can help @magik6k with the test work he has in his scope?

Or we maybe have a separate issue that deals with this topic and this one should be closed as obsolete?

@nonsense
Copy link
Member

nonsense commented Jun 8, 2021

This issue should be closed now.

deals end-to-end testplans are now passing.

When they fail it is generally due to three reasons:

  1. lotus-soup/go.mod needs to be updated. (lotus-soup test plan is a separate module from lotus).
  2. Testground as a service (https://ci.testground.ipfs.team/tasks) is temporarily unavailable.
  3. We hit a bug on Lotus.

Addressing these 3 is out of scope of this issue.

@nonsense nonsense closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/test-flakiness Impact: Test Flakiness P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

4 participants