fix: eth: correctly decode EthGetStorageAt output #10284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cbor-encode it. Also: 1. Actually use the passed block param. 2. Check if the target actor is an EVM actor to avoid nonsense outputs. fixes filecoin-project/ref-fvm#1621
raulk
reviewed
Feb 15, 2023
raulk
reviewed
Feb 15, 2023
There was a problem hiding this comment.
A dedicated test would be nice that goes over the different cases here:
- Actor is an evm smart contract and has the storage slot filled => return value.
- Actor is an evm smart contract and does not have the storage slot filled => return 32-byte padded 0.
- Actor is not an evm smart contract => ^^
- Actor does not exist => ^^
(I volunteer to write it tomorrow if you'd like me to.)
node/impl/full/eth.go
Outdated
| l := len(position) | ||
| if l > 32 { | ||
| return nil, fmt.Errorf("supplied storage key is too long") | ||
| } | ||
|
|
||
| // pad with zero bytes if smaller than 32 bytes | ||
| position = append(make([]byte, 32-l, 32-l), position...) | ||
| position = append(make([]byte, 32-l), position...) |
There was a problem hiding this comment.
supernit: Could move this below to where it's used.
There was a problem hiding this comment.
I have that there to put it next to the length check. I kept the length check at the top to fail early when passed an invalid parameter.
raulk
approved these changes
Feb 15, 2023
|
Test issue: #10407 |
jennijuju
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes filecoin-project/ref-fvm#1621
(probably)
Proposed Changes
Correctly decode actor output in EthGetStorageAt, and test it.
Also: