feat: EthAPI: Add EthAddressToFilecoinAddress #10286
Conversation
arajasek
force-pushed
the
asr/eth-address-api
branch
from
c7d1f6a
to
80942d5
Compare
| @@ -0,0 +1,35 @@ | |||
| package itests | |||
|
|
|||
There was a problem hiding this comment.
Don't have a strong opinion on this but maybe move this to fevm_address_test.go and rename that file to eth_address_test.go since that name does cover this domain
There was a problem hiding this comment.
I think we need to have a dedicated test suite for the EthAPI, my hope is that this will be the start of that.
There was a problem hiding this comment.
Fair point but the Eth API seems very large to stick in a single file?
| ctx, cancel := context.WithTimeout(context.Background(), time.Minute) | ||
| defer cancel() | ||
|
|
||
| secpKey, err := key.GenerateKey(types.KTDelegated) |
There was a problem hiding this comment.
Is this still a secpKey since the type here is delegated?
There was a problem hiding this comment.
Yes, "Delegated" signature keys are solely secp.
There was a problem hiding this comment.
For my own knowledge,
We also have a secp address type which I presume have secp keys
What is the mapping of address types to key types? Are those orthogonal concepts?
There was a problem hiding this comment.
So this is a little gnarly. Secp addresses correspond to secp keys. Delegated addresses today solely correspond to secp keys. They will eventually support other kinds of signatures, such as "account abstraction".
So why do we have the KTDelegated sigtype today? It's because the Lotus keystore couples the stored key with its address representation. So when working with keys, we need to treat delegated sigtypes differently from secp sigtypes (eg. here).
itests/eth_api_test.go
Outdated
| apiFilAddr, err := client.EthAddressToFilecoinAddress(ctx, ethAddr) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, filecoinAddr, apiFilAddr) |
There was a problem hiding this comment.
Could you enhance this test or add another test, to test the conversion for non delegated addresses?
arajasek
force-pushed
the
asr/eth-address-api
branch
from
80942d5
to
2c0a0a5
Compare
arajasek
force-pushed
the
asr/eth-address-api
branch
from
2c0a0a5
to
1d0a524
Compare
Related Issues
Fixes #10279
Proposed Changes
Simple API that users can call to go from EthAddresses to Filecoin Addresses
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps