feat: eth: parse revert data #10295
Merged
feat: eth: parse revert data #10295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Feb 16, 2023
We don't really want to do this in the FVM because it's Ethereum specific, but this makes sense to do in the Ethereum API. See: See https://docs.soliditylang.org/en/latest/control-structures.html#panic-via-assert-and-error-via-require
Stebalien
force-pushed
the
steb/parse-eth-revert
branch
from
8e6e078 to
ef87651
Compare
shrenujbansal
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Parse the revert data and include it in the error message of EthCall to improve degradability. We don't really want to do this in the FVM because it's Ethereum (solidity) specific, but this makes sense to do in the Ethereum API. It might also make sense to do in the EVM itself, but it's too late to consider that right now.
This change only applies to
EthCall. The next step is to improve the error message output fromEthEstimateGas.Additional Info
See https://docs.soliditylang.org/en/latest/control-structures.html#panic-via-assert-and-error-via-require
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps