Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Hide lotus-worker set command #10384

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 3, 2023

Related Issues

Fixes #10210, Fixes #7866

Proposed Changes

Based on the discussion in #10210 and in #7866, I propose to hide this command and start the deprecation process of this function.

The desired feature from our users point of view will be fulfilled by the lotus-worker tasks enable/disable, which allows SPs to gracefully shutdown the lotus-worker even with incoming sealing tasks:

  1. SP have a lot of incoming sealing tasks in the pipeline, but want/need to shut down worker nr.124 for maintainence/upgrade
  2. Issue the lotus-worker tasks disable --all, and let the remaining sealing tasks finish and let other workers fetch the finished sectors.
  3. lotus-worker stop to detach it and do maintenance/upgrades.

Additional Info

A follow up here is to document how to gracefully shutdown a lotus-worker to our users: filecoin-project/lotus-docs#511

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Hide the `lotus-worker set` command and print that this command will be deprecated.
@rjan90 rjan90 requested a review from a team as a code owner March 3, 2023 13:25
@rjan90 rjan90 modified the milestones: v1.21.1, v1.21.0 Mar 3, 2023
@rjan90 rjan90 merged commit 6c0a2fe into master Mar 5, 2023
@rjan90 rjan90 deleted the fix/hide-set-worker-cmd branch March 5, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants