fix: cli: Hide lotus-worker set
command
#10384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #10210, Fixes #7866
Proposed Changes
Based on the discussion in #10210 and in #7866, I propose to hide this command and start the deprecation process of this function.
The desired feature from our users point of view will be fulfilled by the
lotus-worker tasks enable/disable
, which allows SPs to gracefully shutdown the lotus-worker even with incoming sealing tasks:lotus-worker tasks disable --all
, and let the remaining sealing tasks finish and let other workers fetch the finished sectors.lotus-worker stop
to detach it and do maintenance/upgrades.Additional Info
A follow up here is to document how to gracefully shutdown a lotus-worker to our users: filecoin-project/lotus-docs#511
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps