Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state: short-circuit genesis state computation #10397

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 6, 2023

Related Issues

@magik6k observed that the recently added TestEthGetGenesis is flaky. The cause is that our state computation of the first epoch needs short-circuiting to handle certain special-casing (eg. a WinCount of 0).

Proposed Changes

This special-casing already exists, but lived one level too high for tooling like StateCompute. Moving it down one level fixes the issue.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 6, 2023 20:42
@arajasek arajasek requested a review from magik6k March 6, 2023 20:42
@arajasek arajasek merged commit b88ecb7 into master Mar 6, 2023
@arajasek arajasek deleted the asr/fix-genesis-state-compute branch March 6, 2023 20:57
@jennijuju jennijuju mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants