Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: API Gateway: patch documentation note about make gen command #10422

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

ArseniiPetrovich
Copy link
Contributor

Related Issues

Proposed Changes

Simple code comment update around gateway patch

Additional Info

make gen didn't work with me. Then @jennijuju proposed to use make clean && make all first, which helped. I think it would be great to have full command here

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • CI is green

@ArseniiPetrovich ArseniiPetrovich requested a review from a team as a code owner March 8, 2023 16:58
@magik6k
Copy link
Contributor

magik6k commented Mar 8, 2023

make deps instead of make all should also work, but be way faster

@ArseniiPetrovich
Copy link
Contributor Author

Yes, worked for me :)

@magik6k magik6k merged commit f9c8cb0 into filecoin-project:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants