fix: ethrpc: Don't lock up when eth subscriber goes away #10485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
changed the title
magik6k
commented
Mar 15, 2023
go.mod
Outdated
| @@ -319,6 +320,7 @@ require ( | |||
| github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 // indirect | |||
| github.com/zondax/hid v0.9.1 // indirect | |||
| github.com/zondax/ledger-go v0.12.1 // indirect | |||
| github.com/zyedidia/generic v1.2.1 // indirect | |||
There was a problem hiding this comment.
This is a very small library with a bunch of very nice generic helpers. Wanted to use it since forever, finally got a quality excuse.
ZenGround0
approved these changes
Mar 15, 2023
|
|
||
| for _, f := range e.filters { | ||
| // note: the context in actually unused in uninstallFilter | ||
| if err := e.uninstallFilter(context.TODO(), f); err != nil { |
There was a problem hiding this comment.
double checking: these don't take long and won't hang node shutdown right?
|
Looking good Magik!! I've tested across three stack restarts and 8 Boost restarts and have been able to start every time!! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #10484
Brings in filecoin-project/go-jsonrpc#98
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps