Add feature to stagger sector prove commit submission #10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Mar 23, 2023
magik6k
reviewed
Mar 23, 2023
storage/pipeline/commit_batch.go
Outdated
Comment on lines
428
to
429
| time.Sleep(builtin.EpochDurationSeconds * time.Second) | ||
| sectorsProcessed = 0 |
There was a problem hiding this comment.
I'd try to avoid the sleep in any way possible.
Polling api.ChainHead every 2-3s, and looking for height change is probably good enough
There was a problem hiding this comment.
Out of curiosity, why should we try to avoid sleep? And what would be the difference between the 2 approaches? Seems like they'd have the same end result of waiting for around an epoch
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
…n-project/lotus into sbansal/max-prove-commits-submit
magik6k
reviewed
Mar 24, 2023
magik6k
approved these changes
Mar 27, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#7002
Proposed Changes
Add a config to allow SPs to stagger sector prove commit submissions
This is done because gas estimates for ProveCommits are non deterministic and increasing as a large number of sectors get committed within the same epoch resulting in occasionally failed msgs. Submitting a smaller number of prove commits per epoch would reduce the possibility of failed msgs
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps