feat: stmgr: speed up calculation of genesis circ supply #10553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chain/stmgr/supply.go
Outdated
| err := sm.setupGenesisVestingSchedule(ctx) | ||
| if err != nil { | ||
| return vf, xerrors.Errorf("failed to setup pre-ignition vesting schedule: %w", err) | ||
| } | ||
| sm.genesisMsigLk.Unlock() |
There was a problem hiding this comment.
Each of these unlocks don't happen if we err out on the line above
There was a problem hiding this comment.
Quite right, I'll move it up above the err return.
arajasek
force-pushed
the
asr/drop-genesis-marketfund
branch
from
2e78d84
to
4d60f6e
Compare
chain/stmgr/supply.go
Outdated
| // TODO: combine all this? | ||
| if sm.preIgnitionVesting == nil || sm.genesisPledge.IsZero() || sm.genesisMarketFunds.IsZero() { | ||
| if sm.preIgnitionVesting == nil || sm.genesisPledge.IsZero() { | ||
| sm.genesisMsigLk.Lock() |
There was a problem hiding this comment.
I think it might make more sense to move this lock into each of the vesting functions as they are also owned by the state manager and we are trying to make this lock more granular
There was a problem hiding this comment.
Sure, I'm happy to do that. Note that we should only be calling each of these methods once, but I think that makes sense.
arajasek
force-pushed
the
asr/drop-genesis-marketfund
branch
from
4d60f6e
to
bc87017
Compare
shrenujbansal
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@jennijuju's goroutines reported that when trying to send many messages (or just create a lot of FVMs), this lock becomes contended for.
Proposed Changes
genesisMarketFunds, which is zero on mainnet (confirmed)genesisMarketFundswas equal to 0Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps