Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:splitstore:Update config default value #10605

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

ZenGround0
Copy link
Contributor

Related Issues

#10580

Proposed Changes

Set splitstore max space config as default

Additional Info

This config value will bound total lotus hotstore space during moves between 500 - 650 GiB by default
Reviewers should advise if this is too small / the resources needed for frequent moves is expected to be too burdensome
We should probably land this alongside #10392 so that more frequent moving GCs have less impact on chain sync

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 30, 2023 18:36
@rjan90 rjan90 mentioned this pull request Apr 4, 2023
7 tasks
rjan90 added a commit that referenced this pull request Apr 4, 2023
@ZenGround0 ZenGround0 merged commit da6b565 into master Apr 10, 2023
@ZenGround0 ZenGround0 deleted the splitstore/config-update branch April 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants