Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:releasepolish v1.22 release #10666

Merged
merged 8 commits into from
Apr 13, 2023

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Apr 13, 2023

Related Issues

Proposed Changes

Additional Info

RC3

  • Register v11 actors so state read-state commands will work among other things
  • Update calibration to happen 4-20 16:30 UTC
  • Add shed inspection commands of SI and market cron used to confirm butterfly state and useful for calibration

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner April 13, 2023 19:41
@ZenGround0 ZenGround0 changed the title Chore/polish v1.22 release chore:releasepolish v1.22 release Apr 13, 2023
Copy link
Contributor

@shrenujbansal shrenujbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for the most part. Could you fix gen and lint checks?
Also could you post an example output of the lotus-shed cmds you just added?

@ZenGround0
Copy link
Contributor Author

ZenGround0 commented Apr 13, 2023

cron state command

Assuming at tipset height 300 there are three deals, dealid 1 scheduled for cron process at epoch 1000, dealid 2 and 3 scheduled for 1001 we get:

lotus-shed market cron-state --tipset=@300
{"1000":[1], "1001":[2,3]}

tipset flag is optional defaulting to head

sector info command

Same optional tipset flag, arguments are miner address and sector number

./lotus-shed miner sectorinfo --tipset=@296 t01012 64                                       
8f184007d82a5829000182e20381e80220f484322806367e97188763a81fda5618675f3bdd47fa5ce7a97c065a3c8f175e801901201a0017a4fc404048003782dac0000000480023d24224dd85674800552adf417114230040f6f5

I went with raw cbor so that this will work the same across all actors versions + using cbor.me is pretty easy for the simple struct. It is also nice to work with raw bytes because we immediately get size of sector info.

@shrenujbansal
Copy link
Contributor

I went with raw cbor so that this will work the same across all actors versions + using cbor.me is pretty easy for the simple struct. It is also nice to work with raw bytes because we immediately get size of sector info.

I would actually convert this into something consumable by human eyes. Cbor output is not very useful to look at without having to insert into another tool

@ZenGround0
Copy link
Contributor Author

I would actually convert this into something consumable by human eyes. Cbor output is not very useful to look at without having to insert into another tool

I wouldn't land it like this into lotus proper but this is lotus-shed so think functional tools tools for getting work done that are rough around the edges. Using raw bytes makes handling all past and future network versions trivially easy. This way I was able to use the tool to inspect different sector info schemas at nv18 and nv19 to complete butterfly testing. The alternative is a lot of error handling and updating on format upgrade which will realistically always go stale and make this break and unused.

@ZenGround0 ZenGround0 merged commit ff9e706 into release/v1.22.0 Apr 13, 2023
@ZenGround0 ZenGround0 deleted the chore/polish-v1.22-release branch April 13, 2023 21:21
ZenGround0 added a commit that referenced this pull request Apr 19, 2023
* Update butterfly artifacts

* register actors v11

* Update calibration upgrade time

* State inspection shed cmds

* Fix

* make gen

* Fix swallowed errors

* Lint fixup

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
ZenGround0 added a commit that referenced this pull request Apr 19, 2023
* chore: update ffi to increase execution parallelism

* Don't enforce walking receipt tree during compaction

* fix: build: drop drand incentinet servers

* chore: release lotus v1.20.4

* Apply suggestions from code review

Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

* feat: Introduce nv19 skeleton

Update to go-state-types v0.11.0-alpha-1

Introduce dummy v11 actor bundles

Make new actors adapters

Add upgrade to Upgrade Schedules

make jen

Update to go-state-types v0.11.0-alpha-2

* feat: vm: switch to the new exec trace format (#10372)

This is now "FVM" native. Changes include:

1. Don't treat "trace" messages like off-chain messages. E.g., don't
include CIDs, versions, etc.
2. Include IPLD codecs where applicable.
3. Remove fields that aren't filled by the FVM (timing, some errors,
code locations, etc.).

* feat: implement FIP-0061

* Address review

* Add and test the FIP-0061 migration

* Update actors bundles to fip/20230406

* Update to go-state-types master

* Update to actors v11.0.0-rc1

* - Update go state types
- Keep current expiration defaults on creation, extension some tests
- Update ffi

* ffi experiment

* Integration nv19 migration

- Open splitstore in migration shed tool
- Update state root version

* Post rebase fixup

* Fix

* gen

* nv19 invariant checking

* Try fixig blockstore so bundle is loaded

* Debug

* Fix

* Make butterfly upgrades happen

* Another ffi experiment

* Fix copy paste error

* Actually schedule migration (#10656)

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* Butterfly artifacts

* Set calibration net upgrade height

* Review Response

* Fix state tree version assert

* Quick butterfly upgrade to sanity check (#10660)

* Quick butterfly upgrade to sanity check

* Update butterfly artifacts

* Revert fake fix

* Give butterfly net correct genesis

* Butterfly artifacts

* Give time before upgrade

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* chore:releasepolish v1.22 release (#10666)

* Update butterfly artifacts

* register actors v11

* Update calibration upgrade time

* State inspection shed cmds

* Fix

* make gen

* Fix swallowed errors

* Lint fixup

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* v1.22.0-rc3

* bundle fix

* Feat/expedite nv19 (#10681)

* Update go-state-types

* Modify upgrade schedule and params

* Revert fip 0052

* Update gst

* docsgen

* fast butterfly migration to validate migration

* Correct epoch to match specified date

* Update actors v11

* Update changelog build version

* Update butterfly artifacts

* Fix lotus-miner init to work after upgrade

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* fix:deps:stable ffi for stable release  (#10698)

* Point to stable ffi for stable lotus release

* go mod tidy

---------

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

---------

Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: jennijuju <jiayingw703@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants